[Mac] Reverse the omnibox in RTL

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"
 
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"  // IDC_*
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser_list.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
+#include "chrome/browser/ui/cocoa/l10n_util.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/grit/generated_resources.h"
 #import "ui/base/cocoa/find_pasteboard.h"
 #import "ui/base/cocoa/touch_bar_forward_declarations.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/material_design/material_design_controller.h"
 
 namespace {
@@ skipping 62 matching lines @@
 
     forbiddenCharacters_.reset([[NSCharacterSet controlCharacterSet] retain]);
 
     // Disable all substitutions by default. In regular NSTextFields a user may
     // selectively enable them via context menu, but that submenu is not enabled
     // for the omnibox. The substitutions are unlikely to be useful in any case.
     //
     // Also see http://crbug.com/173405 and http://crbug.com/528014.
     NSTextCheckingTypes checkingTypes = 0;
     [self setEnabledTextCheckingTypes:checkingTypes];
+    self.alignment = cocoa_l10n_util::ShouldDoExperimentalRTLLayout()
+                         ? NSRightTextAlignment
+                         : NSLeftTextAlignment;

[Sidney San Martín, 2016/12/16 00:05:54]

The docs suggest that NSNaturalTextAlignment would work for both… Does it?

https://developer.apple.com/library/content/documentation/MacOSX/Conceptual/B...

[lgrey, 2016/12/20 19:41:04]

At least in forced RTL, this doesn't hold for the empty string.  OTOH, it looks
like crrev.com/2555783002 was sufficient for changing this by setting the
field's alignment (vs. the editors), so reverting.

   }
   return self;
 }
 
 // Overridden to prevent unwanted items from appearing in the Touch Bar.
 - (NSTouchBar*)makeTouchBar {
   return nil;
 }
 
 - (void)updateColorsToMatchTheme {
@@ skipping 518 matching lines @@
 // ThemedWindowDrawing implementation.
 
 - (void)windowDidChangeTheme {
   [self updateColorsToMatchTheme];
 }
 
 - (void)windowDidChangeActive {
 }
 
 @end