Roll clang 288545:288545.

Roll clang 288545:288545.

Ran `./tools/clang/scripts/upload_revision.py 288545 2016121301`.

BUG=

[Nico, 2016-12-14 23:39:13]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-12-14 23:39:13]

https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:460: if sys.platform == 'win32' or
sys.platform.startswith('linux') or use_head_revision:
Sending this to the upload bots just cost me over an hour. This added lld
locally to the bots, but only on this try job. Future jobs then had this old
checkout of lld flying around that never got updated, and that led to test
failures.

Please don't use the upload bots for testing stuff that adds folders to the
checkout.

[hans, 2016-12-14 23:42:56]

On 2016/12/14 23:39:13, Nico wrote:
>
https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
> File tools/clang/scripts/update.py (right):
> 
>
https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
> tools/clang/scripts/update.py:460: if sys.platform == 'win32' or
> sys.platform.startswith('linux') or use_head_revision:
> Sending this to the upload bots just cost me over an hour. This added lld
> locally to the bots, but only on this try job. Future jobs then had this old
> checkout of lld flying around that never got updated, and that led to test
> failures.
> 
> Please don't use the upload bots for testing stuff that adds folders to the
> checkout.

We should think about making the script robust against this kind of thing
though. I think most developers, myself included, assume the trybots run with a
clean slate each time, and this is pretty sneaky.

[krasin1, 2016-12-14 23:46:44]

On 2016/12/14 23:39:13, Nico wrote:
>
https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
> File tools/clang/scripts/update.py (right):
> 
>
https://codereview.chromium.org/2576553002/diff/20001/tools/clang/scripts/upd...
> tools/clang/scripts/update.py:460: if sys.platform == 'win32' or
> sys.platform.startswith('linux') or use_head_revision:
> Sending this to the upload bots just cost me over an hour. This added lld
> locally to the bots, but only on this try job. Future jobs then had this old
> checkout of lld flying around that never got updated, and that led to test
> failures.
> 
> Please don't use the upload bots for testing stuff that adds folders to the
> checkout.

Sorry. :(

[krasin1, 2016-12-14 23:47:38]

But yes, we shall make the bot less fragile, as this particular try was to test
that everything works on the bot. Locally, it worked even without the change.