Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257643002: Enable the mediaControlsOverlayPlayButtonEnabled setting on Android (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, acolwell GONE FROM CHROMIUM
Visibility:
Public.

Description

Enable the mediaControlsOverlayPlayButtonEnabled setting on Android BUG=366675 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/resources/webkit_resources.grd View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
philipj_slow
Patch 1: https://codereview.chromium.org/250533003/ Patch 2: this Patch 3: https://codereview.chromium.org/254633002/ I'd like to get all three ...
6 years, 8 months ago (2014-04-26 00:19:56 UTC) #1
darin (slow to review)
LGTM (I'm deferring the decision to include this resource on non-Android to acolwell@ who LGTM'd ...
6 years, 8 months ago (2014-04-26 01:39:11 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-28 21:24:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/257643002/1
6 years, 7 months ago (2014-04-28 21:25:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:29:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 21:29:13 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-28 21:53:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/257643002/1
6 years, 7 months ago (2014-04-28 21:53:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:30:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 22:30:34 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-29 07:32:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/257643002/1
6 years, 7 months ago (2014-04-29 07:33:09 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 09:28:05 UTC) #13
Message was sent while issue was closed. 
Change committed as 266800

Powered by Google App Engine
This is Rietveld 408576698