Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: tools/perf/page_sets/page_cycler_story.py

Issue 2576403005: Further increase the navigation timeout to 180s for page cycler stories (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page 5 from telemetry.page import page
6 from telemetry.page import cache_temperature as cache_temperature_module 6 from telemetry.page import cache_temperature as cache_temperature_module
7 from telemetry.page import shared_page_state 7 from telemetry.page import shared_page_state
8 8
9 9
10 _TTI_WAIT_TIME = 10 10 _TTI_WAIT_TIME = 10
11 _NAVIGATION_TIMEOUT = 180
11 _WEB_CONTENTS_TIMEOUT = 180 12 _WEB_CONTENTS_TIMEOUT = 180
12 13
13 class PageCyclerStory(page.Page): 14 class PageCyclerStory(page.Page):
14 15
15 def __init__(self, url, page_set, 16 def __init__(self, url, page_set,
16 shared_page_state_class=shared_page_state.SharedDesktopPageState, 17 shared_page_state_class=shared_page_state.SharedDesktopPageState,
17 cache_temperature=cache_temperature_module.ANY, **kwargs): 18 cache_temperature=cache_temperature_module.ANY, **kwargs):
18 super(PageCyclerStory, self).__init__( 19 super(PageCyclerStory, self).__init__(
19 url=url, page_set=page_set, 20 url=url, page_set=page_set,
20 shared_page_state_class=shared_page_state_class, 21 shared_page_state_class=shared_page_state_class,
21 cache_temperature=cache_temperature, 22 cache_temperature=cache_temperature,
22 **kwargs) 23 **kwargs)
23 24
24 def RunNavigateSteps(self, action_runner): 25 def RunNavigateSteps(self, action_runner):
25 url = self.file_path_url_with_scheme if self.is_file else self.url 26 url = self.file_path_url_with_scheme if self.is_file else self.url
26 action_runner.Navigate(url, 27 action_runner.Navigate(url,
27 self.script_to_evaluate_on_commit, 28 self.script_to_evaluate_on_commit,
28 timeout_in_seconds = 120) 29 timeout_in_seconds=_NAVIGATION_TIMEOUT)
29 30
30 def RunPageInteractions(self, action_runner): 31 def RunPageInteractions(self, action_runner):
31 action_runner.tab.WaitForDocumentReadyStateToBeComplete( 32 action_runner.tab.WaitForDocumentReadyStateToBeComplete(
32 _WEB_CONTENTS_TIMEOUT) 33 _WEB_CONTENTS_TIMEOUT)
33 action_runner.Wait(_TTI_WAIT_TIME) 34 action_runner.Wait(_TTI_WAIT_TIME)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698