Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py

Issue 2576353003: Change ChromiumCommit.format_patch to use a filtered list of files (Closed)
Patch Set: Address CL feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 from webkitpy.w3c.local_wpt import LocalWPT 7 from webkitpy.w3c.local_wpt import LocalWPT
8 from webkitpy.w3c.chromium_commit import ChromiumCommit 8 from webkitpy.w3c.chromium_commit import ChromiumCommit
9 from webkitpy.w3c.deps_updater import DepsUpdater 9 from webkitpy.w3c.deps_updater import DepsUpdater
10 10
11 _log = logging.getLogger(__name__) 11 _log = logging.getLogger(__name__)
12
13 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/imported/wpt/' 12 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/imported/wpt/'
qyearsley 2016/12/21 00:24:46 Optionally, no need to remove this line; this file
jeffcarp 2016/12/21 19:12:52 Done
14 13
15 14
16 class TestExporter(object): 15 class TestExporter(object):
17 16
18 def __init__(self, host, wpt_github, dry_run=False): 17 def __init__(self, host, wpt_github, dry_run=False):
19 self.host = host 18 self.host = host
20 self.wpt_github = wpt_github 19 self.wpt_github = wpt_github
21 self.dry_run = dry_run 20 self.dry_run = dry_run
22 21
23 def run(self): 22 def run(self):
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 128
130 return filter(is_exportable, chromium_commits) 129 return filter(is_exportable, chromium_commits)
131 130
132 def _has_expectations(self, chromium_commit): 131 def _has_expectations(self, chromium_commit):
133 files = self.host.executive.run_command([ 132 files = self.host.executive.run_command([
134 'git', 'diff-tree', '--no-commit-id', 133 'git', 'diff-tree', '--no-commit-id',
135 '--name-only', '-r', chromium_commit.sha 134 '--name-only', '-r', chromium_commit.sha
136 ]).splitlines() 135 ]).splitlines()
137 136
138 return any(DepsUpdater.is_baseline(f) for f in files) 137 return any(DepsUpdater.is_baseline(f) for f in files)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698