[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

chromeos/components/tether/ble_advertisement_device_queue_unittest.cc

Index: chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
diff --git a/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc b/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..51de39043c2f32e1b21a695f92a3bd0cc13ed147
--- /dev/null
+++ b/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
@@ -0,0 +1,173 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.

[Ryan Hansberry, 2016/12/19 20:06:52]

2016

[Kyle Horimoto, 2016/12/19 20:15:03]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/components/tether/ble_advertisement_device_queue.h"
+
+#include <memory>
+
+#include "components/cryptauth/remote_device_test_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::ElementsAre;
+
+namespace chromeos {
+
+namespace tether {
+
+class BleAdvertisementDeviceQueueTest : public testing::Test {
+ protected:
+  BleAdvertisementDeviceQueueTest() : device_queue_(nullptr) {}
+
+  void SetUp() override {
+    device_queue_.reset(new BleAdvertisementDeviceQueue());
+  }
+
+  std::unique_ptr<BleAdvertisementDeviceQueue> device_queue_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BleAdvertisementDeviceQueueTest);
+};
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestEmptyQueue) {
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_EQ(static_cast<size_t>(0), device_queue_->GetSize());
+  EXPECT_TRUE(to_advertise.empty());
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestSingleDevice) {
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(1);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_EQ(static_cast<size_t>(1), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestSingleDevice_MoveToEnd) {
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(1);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_EQ(static_cast<size_t>(1), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0]));
+
+  device_queue_->MoveDeviceToEnd(devices[0].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestTwoDevices) {
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(2);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_EQ(static_cast<size_t>(2), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0], devices[1]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestTwoDevices_MoveToEnd) {
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(2);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_EQ(static_cast<size_t>(2), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0], devices[1]));
+
+  device_queue_->MoveDeviceToEnd(devices[0].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[1], devices[0]));
+
+  device_queue_->MoveDeviceToEnd(devices[1].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0], devices[1]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestThreeDevices) {
+  // Note: These tests need to be rewritten if MAX_CONCURRENT_ADVERTISEMENTS is
+  // ever changed.
+  ASSERT_GT(3, BleAdvertisementDeviceQueue::kMaxConcurrentAdvertisements);
+
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(3);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_EQ(static_cast<size_t>(3), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0], devices[1]));
+
+  device_queue_->MoveDeviceToEnd(devices[0].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[1], devices[2]));
+
+  device_queue_->MoveDeviceToEnd(devices[1].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[2], devices[0]));
+
+  device_queue_->MoveDeviceToEnd(devices[2].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(devices[0], devices[1]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestAddingDevices) {
+  // Note: These tests need to be rewritten if MAX_CONCURRENT_ADVERTISEMENTS is
+  // ever changed.
+  ASSERT_GT(3, BleAdvertisementDeviceQueue::kMaxConcurrentAdvertisements);
+
+  std::vector<cryptauth::RemoteDevice> all_devices =
+      cryptauth::GenerateTestRemoteDevices(5);
+  std::vector<cryptauth::RemoteDevice> initial_devices = {all_devices[0],
+                                                          all_devices[1]};
+  std::vector<cryptauth::RemoteDevice> updated_devices_list = {
+      all_devices[1], all_devices[2], all_devices[3], all_devices[4]};
+
+  EXPECT_TRUE(device_queue_->SetDevices(initial_devices));
+  EXPECT_EQ(static_cast<size_t>(2), device_queue_->GetSize());
+
+  std::vector<cryptauth::RemoteDevice> to_advertise =
+      device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(all_devices[0], all_devices[1]));
+
+  device_queue_->MoveDeviceToEnd(all_devices[0].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(all_devices[1], all_devices[0]));
+
+  // Device #1 has been unregistered; Devices #3 and #4 have been registered.
+  EXPECT_TRUE(device_queue_->SetDevices(updated_devices_list));
+  EXPECT_EQ(static_cast<size_t>(4), device_queue_->GetSize());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(all_devices[1], all_devices[2]));

[Ryan Hansberry, 2016/12/19 20:06:52]

nit: Is there an expected consistency to having expected value vs. test values
as left/right arguments? For instance, your EXPECT_EQ(static_cast<size_t>(4),
device_queue_->GetSize()); call has the expected value as the left-side arg, but
here the expected value is on the right.

[Kyle Horimoto, 2016/12/19 20:15:03]

The EXPECT_EQ() always takes expected first and actual second.

EXPECT_THAT() takes the test array and allows you to pass other matchers, such
as ElementsAre(). This is the correct way to test this.

+
+  device_queue_->MoveDeviceToEnd(all_devices[2].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(all_devices[1], all_devices[3]));
+
+  device_queue_->MoveDeviceToEnd(all_devices[1].GetDeviceId());
+  to_advertise = device_queue_->GetDevicesToWhichToAdvertise();
+  EXPECT_THAT(to_advertise, ElementsAre(all_devices[3], all_devices[4]));
+}
+
+TEST_F(BleAdvertisementDeviceQueueTest, TestSettingSameDevices) {
+  std::vector<cryptauth::RemoteDevice> devices =
+      cryptauth::GenerateTestRemoteDevices(2);
+  EXPECT_TRUE(device_queue_->SetDevices(devices));
+  EXPECT_FALSE(device_queue_->SetDevices(devices));
+  EXPECT_FALSE(device_queue_->SetDevices(devices));

[Ryan Hansberry, 2016/12/19 20:06:52]

Any reason to have this call twice?

[Kyle Horimoto, 2016/12/19 20:15:03]

Yes, this test is meant to test setting the same devices multiple times.

+  EXPECT_TRUE(
+      device_queue_->SetDevices(cryptauth::GenerateTestRemoteDevices(3)));
+}
+
+}  // namespace tether
+
+}  // namespace cryptauth