Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: ui/ozone/platform/drm/gpu/drm_buffer.cc

Issue 2576263002: ozone: Allocate scanout buffer according to KMS modifiers (Closed)
Patch Set: ozone: Allocate scanout buffer according to KMS modifiers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/drm_buffer.cc
diff --git a/ui/ozone/platform/drm/gpu/drm_buffer.cc b/ui/ozone/platform/drm/gpu/drm_buffer.cc
index 3acbe62c93e76eebf296c0188185d3a2c1dad08b..17bc5d3bca72038c4ae04e114fc6150939e9e2cd 100644
--- a/ui/ozone/platform/drm/gpu/drm_buffer.cc
+++ b/ui/ozone/platform/drm/gpu/drm_buffer.cc
@@ -71,7 +71,8 @@ bool DrmBuffer::Initialize(const SkImageInfo& info,
uint32_t offsets[4] = {0};
fb_pixel_format_ = GetFourCCCodeForSkColorType(info.colorType());
if (!drm_->AddFramebuffer2(info.width(), info.height(), fb_pixel_format_,
- handles, strides, offsets, &framebuffer_, 0)) {
+ handles, strides, offsets, nullptr,
Daniele Castagna 2016/12/20 18:03:28 I personally don't like passing a nullptr for an a
hoegsberg1 2016/12/22 23:05:20 ¯\_(ツ)_/¯
+ &framebuffer_, 0)) {
PLOG(ERROR) << "DrmBuffer: AddFramebuffer2: handle " << handle_;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698