ozone: Allocate scanout buffer according to KMS modifiers

ui/ozone/platform/drm/gpu/gbm_buffer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_OZONE_PLATFORM_DRM_GPU_GBM_BUFFER_H_
 #define UI_OZONE_PLATFORM_DRM_GPU_GBM_BUFFER_H_
 
 #include <vector>
 
 #include "base/files/scoped_file.h"
@@ skipping 10 matching lines @@
 class GbmDevice;
 class GbmSurfaceFactory;
 
 class GbmBuffer : public GbmBufferBase {
  public:
   static scoped_refptr<GbmBuffer> CreateBuffer(
       const scoped_refptr<GbmDevice>& gbm,
       uint32_t format,
       const gfx::Size& size,
       uint32_t usage);
+  static scoped_refptr<GbmBuffer> CreateBufferWithModifiers(

[Daniele Castagna, 2016/12/16 00:27:41]

Why do we need CreateBufferWithModifiers? Can't we just add modifiers to
CreateBuffer?

[hoegsberg1, 2016/12/17 01:10:49]

Hm, I suppose we could just do that. It's a little subtle though that in case it
receive a modifier list it completely ignores the flags. So you get different
semantics whether or not you pass in a modifier vector.

[dnicoara, 2016/12/19 19:44:46]

Should |flags| be removed from the definition then?

+      const scoped_refptr<GbmDevice>& gbm,
+      uint32_t format,
+      const gfx::Size& size,
+      uint32_t flags,
+      const uint64_t *modifiers, uint32_t nmodifiers);
   static scoped_refptr<GbmBuffer> CreateBufferFromFds(
       const scoped_refptr<GbmDevice>& gbm,
       uint32_t format,
       const gfx::Size& size,
       std::vector<base::ScopedFD>&& fds,
       const std::vector<gfx::NativePixmapPlane>& planes);
   uint32_t GetFormat() const { return format_; }
   uint32_t GetFlags() const { return flags_; }
   bool AreFdsValid() const;
   size_t GetFdCount() const;
   int GetFd(size_t plane) const;
   int GetStride(size_t plane) const;
   int GetOffset(size_t plane) const;
   size_t GetSize(size_t plane) const;
   uint64_t GetFormatModifier(size_t plane) const;
   gfx::Size GetSize() const override;
 
  private:
   GbmBuffer(const scoped_refptr<GbmDevice>& gbm,
             gbm_bo* bo,
             uint32_t format,
             uint32_t flags,
+            uint64_t modifier,
             std::vector<base::ScopedFD>&& fds,
             const gfx::Size& size,
             const std::vector<gfx::NativePixmapPlane>&& planes);
   ~GbmBuffer() override;
 
   uint32_t format_;
   uint32_t flags_;
+  uint64_t modifier_;
   std::vector<base::ScopedFD> fds_;
   gfx::Size size_;
 
   std::vector<gfx::NativePixmapPlane> planes_;
 
   DISALLOW_COPY_AND_ASSIGN(GbmBuffer);
 };
 
 class GbmPixmap : public NativePixmap {
  public:
@@ skipping 34 matching lines @@
   // this Pixmap. This holds the processed buffer.
   scoped_refptr<GbmPixmap> processed_pixmap_;
   ProcessingCallback processing_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(GbmPixmap);
 };
 
 }  // namespace ui
 
 #endif  // UI_OZONE_PLATFORM_DRM_GPU_GBM_BUFFER_H_