Print Preview: Simplify other_options_settings javascript code.

chrome/test/data/webui/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "base/feature_list.h"');
 GEN('#include "chrome/common/chrome_features.h"');
 
 /**
  * Test fixture for print preview WebUI testing.
  * @constructor
@@ skipping 500 matching lines @@
               height_microns: 0,
               is_default: true
             }
           ]
         }
       }
     }
   };
   this.setCapabilities(device);
 
-  checkSectionVisible($('other-options-settings'), false);
+  var otherOptions = $('other-options-settings');
+  checkSectionVisible(otherOptions, false);
   checkSectionVisible($('media-size-settings'), false);
   checkSectionVisible($('scaling-settings'), false);
 
   testDone();
 });
 
 // When the source is 'HTML', we always hide the fit to page option and show
 // media size option.
 TEST_F('PrintPreviewWebUITest', 'SourceIsHTMLCapabilities', function() {
   this.setInitialSettings();
@@ skipping 24 matching lines @@
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'SourceIsPDFCapabilities', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var scalingSettings = $('scaling-settings');
+  var fitToPageContainer =
+      otherOptions.querySelector('.fit-to-page-container');
 
   checkSectionVisible(otherOptions, true);
-  checkElementDisplayed(
-      otherOptions.querySelector('.fit-to-page-container'), true);
+  checkElementDisplayed(fitToPageContainer, true);
   expectTrue(
-      otherOptions.querySelector('.fit-to-page-checkbox').checked);
+      fitToPageContainer.querySelector('.checkbox').checked);
   this.expandMoreSettings();
   checkSectionVisible($('media-size-settings'), true);
   checkSectionVisible(scalingSettings, true);
 
   this.waitForAnimationToEnd('other-options-collapsible');
 });
 
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'ScalingUnchecksFitToPage', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   var scalingSettings = $('scaling-settings');
 
   checkSectionVisible(otherOptions, true);
-  checkElementDisplayed(
-      otherOptions.querySelector('.fit-to-page-container'), true);
+  var fitToPageContainer =
+      otherOptions.querySelector('.fit-to-page-container');
+  checkElementDisplayed(fitToPageContainer, true);
   expectTrue(
-      otherOptions.querySelector('.fit-to-page-checkbox').checked);
+      fitToPageContainer.querySelector('.checkbox').checked);
   this.expandMoreSettings();
   checkSectionVisible($('media-size-settings'), true);
   checkSectionVisible(scalingSettings, true);
 
   //Change scaling input
   var scalingInput = scalingSettings.querySelector('.user-value');
   expectEquals(scalingInput.value, '100');
   scalingInput.stepUp(5);
   expectEquals(scalingInput.value, '105');
 
   // Trigger the event
   var enter = document.createEvent('Event');
   enter.initEvent('keydown');
   enter.keyCode = 'Enter';
   scalingInput.dispatchEvent(enter);
   expectFalse(
-      otherOptions.querySelector('.fit-to-page-checkbox').checked);
+      fitToPageContainer.querySelector('.checkbox').checked);
 
   this.waitForAnimationToEnd('other-options-collapsible');
 });
 
 // When the number of copies print preset is set for source 'PDF', we update
 // the copies value if capability is supported by printer.
 TEST_F('PrintPreviewWebUITest', 'CheckNumCopiesPrintPreset', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
@@ skipping 29 matching lines @@
   var printPresetOptions = {
     duplex: 1
   };
   var printPresetOptionsEvent = new Event(
       print_preview.NativeLayer.EventType.PRINT_PRESET_OPTIONS);
   printPresetOptionsEvent.optionsFromDocument = printPresetOptions;
   this.nativeLayer_.dispatchEvent(printPresetOptionsEvent);
 
   var otherOptions = $('other-options-settings');
   checkSectionVisible(otherOptions, true);
-  checkElementDisplayed(otherOptions.querySelector('.duplex-container'), true);
-  expectTrue(otherOptions.querySelector('.duplex-checkbox').checked);
+  var duplexContainer = otherOptions.querySelector('.duplex-container');
+  checkElementDisplayed(duplexContainer, true);
+  expectTrue(duplexContainer.querySelector('.checkbox').checked);
 
   this.waitForAnimationToEnd('other-options-collapsible');
 });
 
 // Make sure that custom margins controls are properly set up.
 TEST_F('PrintPreviewWebUITest', 'CustomMarginsControlsCheck', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
@@ skipping 275 matching lines @@
 
 // Test to verify that duplex settings are set according to the printer
 // capabilities.
 TEST_F('PrintPreviewWebUITest', 'TestDuplexSettingsTrue', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var otherOptions = $('other-options-settings');
   checkSectionVisible(otherOptions, true);
-  expectFalse(otherOptions.querySelector('.duplex-container').hidden);
-  expectFalse(otherOptions.querySelector('.duplex-checkbox').checked);
+  duplexContainer = otherOptions.querySelector('.duplex-container');
+  expectFalse(duplexContainer.hidden);
+  expectFalse(duplexContainer.querySelector('.checkbox').checked);
 
   this.waitForAnimationToEnd('more-settings');
 });
 
 // Test to verify that duplex settings are set according to the printer
 // capabilities.
 TEST_F('PrintPreviewWebUITest', 'TestDuplexSettingsFalse', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   var device = getCddTemplate("FooDevice");
@@ skipping 15 matching lines @@
 
 // Test that changing the selected printer updates the preview.
 TEST_F('PrintPreviewWebUITest', 'TestPrinterChangeUpdatesPreview', function() {
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
 
   var previewGenerator = mock(print_preview.PreviewGenerator);
   printPreview.previewArea_.previewGenerator_ = previewGenerator.proxy();
 
-  // TODO (rbpotter): Figure out why this is 7 with the addition of scaling,
-  // and if it is a problem.
+  // The number of settings that can change due to a change in the destination
+  // that will therefore dispatch ticket item change events.
   previewGenerator.expects(exactly(7)).requestPreview();
 
   var barDestination;
   var destinations = printPreview.destinationStore_.destinations();
   for (var destination, i = 0; destination = destinations[i]; i++) {
     if (destination.id == 'BarDevice') {
       barDestination = destination;
       break;
     }
   }
@@ skipping 199 matching lines @@
   // appears.
   var advancedSettingsCloseButton = $('advanced-settings').
       querySelector('.close-button');
   checkElementDisplayed(advancedSettingsCloseButton, true);
   checkElementDisplayed($('advanced-settings').
       querySelector('.search-box-area'), true);
 
   this.waitForAnimationToEnd('more-settings');
 });