Mojo: Add RawChannel tests for calling Shutdown() from OnReadMessage()/OnFatalError().

Mojo: Add RawChannel tests for calling Shutdown() from OnReadMessage()/OnFatalError().

Also make RawChannel not call its delegate after Shutdown().

R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265978

[viettrungluu, 2014-04-24 17:40:04]

Surprisingly, this seems to pass on Windows, which may indicate that my test
coverage isn't as good as it should be. Hrm.

[viettrungluu, 2014-04-24 19:02:34]

On 2014/04/24 17:40:04, viettrungluu wrote:
> Surprisingly, this seems to pass on Windows, which may indicate that my test
> coverage isn't as good as it should be. Hrm.

Okay, so it at least sometimes fails, which is good.

[viettrungluu, 2014-04-24 19:16:18]

On 2014/04/24 19:02:34, viettrungluu wrote:
> On 2014/04/24 17:40:04, viettrungluu wrote:
> > Surprisingly, this seems to pass on Windows, which may indicate that my test
> > coverage isn't as good as it should be. Hrm.
> 
> Okay, so it at least sometimes fails, which is good.

(So I disabled it on Windows.)

[viettrungluu, 2014-04-24 19:55:26]

-> sky instead

[sky, 2014-04-24 19:58:27]

LGTM

https://codereview.chromium.org/257623003/diff/20001/mojo/system/raw_channel.cc
File mojo/system/raw_channel.cc (right):

https://codereview.chromium.org/257623003/diff/20001/mojo/system/raw_channel....
mojo/system/raw_channel.cc:143: delegate_ = NULL;
Add a comment as to why it's important to NULL out the delegate here.

[viettrungluu, 2014-04-24 20:02:16]

Thanks.

On 2014/04/24 19:58:27, sky wrote:
> LGTM
> 
>
https://codereview.chromium.org/257623003/diff/20001/mojo/system/raw_channel.cc
> File mojo/system/raw_channel.cc (right):
> 
>
https://codereview.chromium.org/257623003/diff/20001/mojo/system/raw_channel....
> mojo/system/raw_channel.cc:143: delegate_ = NULL;
> Add a comment as to why it's important to NULL out the delegate here.

Done.

[viettrungluu, 2014-04-24 20:02:45]

Committed patchset #3 manually as r265978 (presubmit successful).