Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 2576143002: Tweak payment autofill disabled message in form-not-secure (Closed)
Patch Set: Remove new PopupItemId and remove warning_font_list_ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill_strings.grdp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 external_delegate_->CheckSuggestions( 1622 external_delegate_->CheckSuggestions(
1623 kDefaultPageID, 1623 kDefaultPageID,
1624 Suggestion(l10n_util::GetStringUTF8( 1624 Suggestion(l10n_util::GetStringUTF8(
1625 IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE), 1625 IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE),
1626 l10n_util::GetStringUTF8(IDS_AUTOFILL_HTTP_WARNING_LEARN_MORE), 1626 l10n_util::GetStringUTF8(IDS_AUTOFILL_HTTP_WARNING_LEARN_MORE),
1627 "httpWarning", POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE), 1627 "httpWarning", POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE),
1628 #if !defined(OS_ANDROID) 1628 #if !defined(OS_ANDROID)
1629 Suggestion("", "", "", POPUP_ITEM_ID_SEPARATOR), 1629 Suggestion("", "", "", POPUP_ITEM_ID_SEPARATOR),
1630 #endif 1630 #endif
1631 Suggestion( 1631 Suggestion(
1632 l10n_util::GetStringUTF8(IDS_AUTOFILL_WARNING_INSECURE_CONNECTION), 1632 l10n_util::GetStringUTF8(IDS_AUTOFILL_WARNING_PAYMENT_DISABLED), "",
1633 "", "", POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE)); 1633 "", POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE));
1634 1634
1635 // Clear the test credit cards and try again -- we shouldn't return a warning. 1635 // Clear the test credit cards and try again -- we shouldn't return a warning.
1636 personal_data_.ClearCreditCards(); 1636 personal_data_.ClearCreditCards();
1637 GetAutofillSuggestions(form, field); 1637 GetAutofillSuggestions(form, field);
1638 // Autocomplete suggestions are queried, but not Autofill. 1638 // Autocomplete suggestions are queried, but not Autofill.
1639 EXPECT_FALSE(external_delegate_->on_suggestions_returned_seen()); 1639 EXPECT_FALSE(external_delegate_->on_suggestions_returned_seen());
1640 } 1640 }
1641 1641
1642 // Test that we don't show the extra "Payment not secure" warning when the page 1642 // Test that we don't show the extra "Payment not secure" warning when the page
1643 // and the form target URL are secure, even when the switch is on. 1643 // and the form target URL are secure, even when the switch is on.
(...skipping 3888 matching lines...) Expand 10 before | Expand all | Expand 10 after
5532 5532
5533 // The driver should always be notified. 5533 // The driver should always be notified.
5534 for (const FormFieldData& field : form.fields) { 5534 for (const FormFieldData& field : form.fields) {
5535 GetAutofillSuggestions(form, field); 5535 GetAutofillSuggestions(form, field);
5536 EXPECT_TRUE(autofill_driver_->did_interact_with_credit_card_form()); 5536 EXPECT_TRUE(autofill_driver_->did_interact_with_credit_card_form());
5537 autofill_driver_->ClearDidInteractWithCreditCardForm(); 5537 autofill_driver_->ClearDidInteractWithCreditCardForm();
5538 } 5538 }
5539 } 5539 }
5540 5540
5541 } // namespace autofill 5541 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698