Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257613006: Change the Android test server's cwd rather than mangle arguments. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Change the Android test server's cwd rather than mangle arguments. This allows even path arguments to be pass-through. BUG=365733 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267320

Patch Set 1 #

Patch Set 2 : Fix empty document root. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M build/android/pylib/chrome_test_server_spawner.py View 2 chunks +4 lines, -5 lines 2 comments Download
M net/test/spawned_test_server/remote_test_server.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
davidben
android_dbg_triggered_tests is red, but they don't seem related to test server changes. Build outputs are ...
6 years, 7 months ago (2014-04-28 21:29:51 UTC) #1
bulach
lgtm, thanks! https://codereview.chromium.org/257613006/diff/20001/build/android/pylib/chrome_test_server_spawner.py File build/android/pylib/chrome_test_server_spawner.py (right): https://codereview.chromium.org/257613006/diff/20001/build/android/pylib/chrome_test_server_spawner.py#newcode205 build/android/pylib/chrome_test_server_spawner.py:205: self.command_line.append('--%s=%s' % (key, value)) probably unrelated, but ...
6 years, 7 months ago (2014-04-29 09:06:21 UTC) #2
davidben
https://codereview.chromium.org/257613006/diff/20001/build/android/pylib/chrome_test_server_spawner.py File build/android/pylib/chrome_test_server_spawner.py (right): https://codereview.chromium.org/257613006/diff/20001/build/android/pylib/chrome_test_server_spawner.py#newcode205 build/android/pylib/chrome_test_server_spawner.py:205: self.command_line.append('--%s=%s' % (key, value)) On 2014/04/29 09:06:21, bulach wrote: ...
6 years, 7 months ago (2014-04-29 16:09:12 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-04-30 07:26:05 UTC) #4
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-04-30 16:03:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/257613006/20001
6 years, 7 months ago (2014-04-30 16:04:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 16:07:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 16:07:18 UTC) #8
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-04-30 19:18:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/257613006/20001
6 years, 7 months ago (2014-04-30 19:19:03 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 20:30:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 267320

Powered by Google App Engine
This is Rietveld 408576698