Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257613004: simplify tools/xsan_build now that make runs ninja (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
borenet, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

simplify tools/xsan_build now that make runs ninja BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M tools/xsan_build View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 8 months ago (2014-04-24 16:08:32 UTC) #1
borenet
LGTM
6 years, 8 months ago (2014-04-24 16:21:27 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-24 17:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/257613004/1
6 years, 8 months ago (2014-04-24 17:11:47 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 18:16:15 UTC) #5
Message was sent while issue was closed. 
Change committed as 14356

Powered by Google App Engine
This is Rietveld 408576698