Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2576113002: fix assert with message (Closed)

Created:
4 years ago by Harry Terkelsen
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove --assert-message flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/options.dart View 1 7 chunks +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Harry Terkelsen
4 years ago (2016-12-14 22:15:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-14 23:25:24 UTC) #3
Harry Terkelsen
Thanks, Siggi! PTAL, I also removed the flag
4 years ago (2016-12-14 23:49:57 UTC) #4
Siggi Cherem (dart-lang)
lgtm!
4 years ago (2016-12-14 23:51:13 UTC) #5
Harry Terkelsen
4 years ago (2016-12-14 23:51:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b840f2d13f7f9545c16eba5780523be048d8248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698