Ship object-fit and object-position.

Ship object-fit and object-position.

Change runtime flag ObjectFitPosition from experimental to stable.

BUG=236331, 236333
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158982

[ojan, 2013-10-04 16:47:15]

lgtm


On Fri, Oct 4, 2013 at 12:56 AM, <mstensho@opera.com> wrote:

> Reviewers: ojan,
>
> Description:
> Ship object-fit and object-position.
>
> Change runtime flag ObjectFitPosition from experimental to stable.
>
> BUG=236331,236333
>
> Please review this at
https://codereview.chromium.**org/25761005/<https://codereview.chromium.org/2...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/blink.git@master<https://chromiu...
>
> Affected files (+1, -1 lines):
>   M Source/core/page/**RuntimeEnabledFeatures.in
>
>
> Index: Source/core/page/**RuntimeEnabledFeatures.in
> diff --git a/Source/core/page/**RuntimeEnabledFeatures.in
> b/Source/core/page/**RuntimeEnabledFeatures.in
> index 74f88a3a463573c9e9411542a9fff3**1df6aba0c1..**
> 2f98d93037447003bb0dfd5df78abf**ca2d7ba5c1 100644
> --- a/Source/core/page/**RuntimeEnabledFeatures.in
> +++ b/Source/core/page/**RuntimeEnabledFeatures.in
> @@ -68,7 +68,7 @@ Media status=stable
>  MediaSource status=stable
>  MediaStream status=stable
>  Notifications status=stable
> -ObjectFitPosition status=experimental
> +ObjectFitPosition status=stable
>  // Only enabled on Android, and for certain layout tests on Linux.
>  OverlayFullscreenVideo
>  PagePopup status=stable
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-04 17:20:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/25761005/1

[commit-bot: I haz the power, 2013-10-04 18:31:17]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[mstensho (USE GERRIT), 2013-10-04 19:42:59]

Ojan, could you take another look, please? I had to update two test
expectations. The list of stable webexposed properties is obvious, but I'm not
100% sure about the special video-object-fit test for stable. I decided against
just deleting it, but do you agree?

[ojan, 2013-10-04 19:53:36]

lgtm

I'm not sure what's up with the media/stable tests either, but this seems fine
either way.

[commit-bot: I haz the power, 2013-10-04 19:53:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/25761005/19001

[commit-bot: I haz the power, 2013-10-04 20:46:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-04 21:39:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/25761005/19001

[commit-bot: I haz the power, 2013-10-04 22:13:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-05 06:34:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/25761005/19001

[commit-bot: I haz the power, 2013-10-05 07:46:15]

Change committed as 158982