Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: syzygy/common/asan_parameters_unittest.cc

Issue 2576003002: Add the ability to defer the initialization of the SyzyAsan crash reporter. (Closed)
Patch Set: Fix comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/common/asan_parameters.cc ('k') | syzygy/instrument/transforms/asan_transform.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/common/asan_parameters_unittest.cc
diff --git a/syzygy/common/asan_parameters_unittest.cc b/syzygy/common/asan_parameters_unittest.cc
index f6f6d66e83cc226918bd5034e3e7da7494f7e781..1c255187351580ba182ded0c4cf35ec12e26157f 100644
--- a/syzygy/common/asan_parameters_unittest.cc
+++ b/syzygy/common/asan_parameters_unittest.cc
@@ -96,6 +96,8 @@ TEST(AsanParametersTest, SetDefaultAsanParameters) {
static_cast<bool>(aparams.prevent_duplicate_corruption_crashes));
EXPECT_EQ(kDefaultReportInvalidAccesses,
static_cast<bool>(aparams.report_invalid_accesses));
+ EXPECT_EQ(kDefaultDeferCrashReporterInitialization,
+ static_cast<bool>(aparams.defer_crash_reporter_initialization));
}
TEST(AsanParametersTest, InflateAsanParametersStackIdsPastEnd) {
@@ -251,6 +253,8 @@ TEST(AsanParametersTest, ParseAsanParametersMinimal) {
static_cast<bool>(iparams.prevent_duplicate_corruption_crashes));
EXPECT_EQ(kDefaultReportInvalidAccesses,
static_cast<bool>(iparams.report_invalid_accesses));
+ EXPECT_EQ(kDefaultDeferCrashReporterInitialization,
+ static_cast<bool>(iparams.defer_crash_reporter_initialization));
}
TEST(AsanParametersTest, ParseAsanParametersMaximal) {
@@ -278,7 +282,8 @@ TEST(AsanParametersTest, ParseAsanParametersMaximal) {
L"--quarantine_flood_fill_rate=0.25 "
L"--enable_feature_randomization "
L"--prevent_duplicate_corruption_crashes "
- L"--report_invalid_accesses";
+ L"--report_invalid_accesses "
+ L"--defer_crash_reporter_initialization";
InflatedAsanParameters iparams;
SetDefaultAsanParameters(&iparams);
@@ -313,6 +318,8 @@ TEST(AsanParametersTest, ParseAsanParametersMaximal) {
EXPECT_EQ(true, static_cast<bool>(
iparams.prevent_duplicate_corruption_crashes));
EXPECT_EQ(true, static_cast<bool>(iparams.report_invalid_accesses));
+ EXPECT_EQ(true,
+ static_cast<bool>(iparams.defer_crash_reporter_initialization));
}
} // namespace common
« no previous file with comments | « syzygy/common/asan_parameters.cc ('k') | syzygy/instrument/transforms/asan_transform.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698