Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: base/BUILD.gn

Issue 2575973002: Add a GN arg to include PartitionAlloc sources (Closed)
Patch Set: address comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 0c4b35fa4cec2faca98dc4d73e87fe9f4fbd18b4..a038579d95c623929ac9b6b9036ffe3c51e9fb0d 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -41,6 +41,9 @@ declare_args() {
# available, except for official builds for now.
enable_memory_task_profiler =
use_experimental_allocator_shim && (!is_official_build || is_syzyasan)
+
+ # Partition alloc is included by default except iOS.
+ use_partition_alloc = !is_ios
}
if (is_android) {
@@ -1235,7 +1238,7 @@ component("base") {
"synchronization/read_write_lock_nacl.cc",
]
- if (!is_ios) {
+ if (use_partition_alloc) {
# Add stuff that doesn't work in NaCl.
sources += [
# PartitionAlloc uses SpinLock, which doesn't work in NaCl (see below).
@@ -2172,7 +2175,9 @@ test("base_unittests") {
set_sources_assignment_filter(sources_assignment_filter)
# TODO(GYP): dep on copy_test_data_ios action.
- } else {
+ }
+
+ if (use_partition_alloc) {
sources += [ "allocator/partition_allocator/partition_alloc_unittest.cc" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698