Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: remoting/host/security_key/security_key_message_handler.h

Issue 2575963002: Handle Security Key requests from outside the remoted session correctly (Closed)
Patch Set: Addressing CR Feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/security_key_message_handler.h
diff --git a/remoting/host/security_key/security_key_message_handler.h b/remoting/host/security_key/security_key_message_handler.h
index c14d393f85b18b32114af1c6ba9e0ccd422b93ea..8df9bb3af576a5d40f504811027c1aaea20c1d19 100644
--- a/remoting/host/security_key/security_key_message_handler.h
+++ b/remoting/host/security_key/security_key_message_handler.h
@@ -58,6 +58,9 @@ class SecurityKeyMessageHandler {
// Used to respond to IPC connection changes.
void HandleIpcConnectionChange(bool connection_established);
+ // Used to indicate an IPC connection error has occurred.
+ void HandleIpcConnectionError();
+
// Handles responses received from the client.
void HandleSecurityKeyResponse(const std::string& response_data);
@@ -79,6 +82,10 @@ class SecurityKeyMessageHandler {
// Signaled when an error occurs.
base::Closure error_callback_;
+ // Used to indicate when we expect the IPC channel to be closed (i.e. in the
+ // invalid session scenario) and when it is an unexpected error.
+ bool expect_ipc_channel_close_ = false;
+
base::ThreadChecker thread_checker_;
DISALLOW_COPY_AND_ASSIGN(SecurityKeyMessageHandler);

Powered by Google App Engine
This is Rietveld 408576698