Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: remoting/host/security_key/security_key_ipc_server_impl.cc

Issue 2575963002: Handle Security Key requests from outside the remoted session correctly (Closed)
Patch Set: Addressing CR Feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/security_key_ipc_server_impl.cc
diff --git a/remoting/host/security_key/security_key_ipc_server_impl.cc b/remoting/host/security_key/security_key_ipc_server_impl.cc
index 4a326c6c7d106f812d91404412be32f8ee92ee4e..e051a26e3703636ee8f18de92697eb88ccbd3c1d 100644
--- a/remoting/host/security_key/security_key_ipc_server_impl.cc
+++ b/remoting/host/security_key/security_key_ipc_server_impl.cc
@@ -161,6 +161,9 @@ void SecurityKeyIpcServerImpl::OnChannelConnected(int32_t peer_pid) {
connection_close_pending_ = true;
}
if (connection_close_pending_) {
+ ipc_channel_->Send(
+ new ChromotingNetworkToRemoteSecurityKeyMsg_InvalidSession());
+
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&SecurityKeyIpcServerImpl::OnChannelError,
weak_factory_.GetWeakPtr()));
@@ -174,6 +177,9 @@ void SecurityKeyIpcServerImpl::OnChannelConnected(int32_t peer_pid) {
timer_.Start(FROM_HERE, initial_connect_timeout_,
base::Bind(&SecurityKeyIpcServerImpl::OnChannelError,
base::Unretained(this)));
+
+ ipc_channel_->Send(
+ new ChromotingNetworkToRemoteSecurityKeyMsg_ConnectionReady());
}
void SecurityKeyIpcServerImpl::OnChannelError() {

Powered by Google App Engine
This is Rietveld 408576698