Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: remoting/host/security_key/security_key_auth_handler_win.cc

Issue 2575963002: Handle Security Key requests from outside the remoted session correctly (Closed)
Patch Set: Addressing CR Feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/security_key_auth_handler_win.cc
diff --git a/remoting/host/security_key/security_key_auth_handler_win.cc b/remoting/host/security_key/security_key_auth_handler_win.cc
index 428c35cf7a505aa4b68f1ae86487cb76b9a35d5f..e8b93b0cb33452ed17e47055489c7f7f903b03f4 100644
--- a/remoting/host/security_key/security_key_auth_handler_win.cc
+++ b/remoting/host/security_key/security_key_auth_handler_win.cc
@@ -50,14 +50,8 @@ namespace remoting {
// Creates an IPC server channel which services IPC clients that want to start
// a security key forwarding session. Once an IPC Client connects to the
// server, the SecurityKeyAuthHandlerWin class will create a new
-// SecurityKeyIpcServer instance that will service that request. The new
-// instance will exist for the lifetime of the security key request and will be
-// assigned a unique IPC channel name and connection id. The channel name is
-// sent to the client which should disconnect the IPC server channel and
-// connect to the security key forwarding session IPC channel to send/receive
-// security key messages. The IPC server channel will then be reset so it can
-// can service the next client/request. This system allows multiple security
-// key forwarding sessions to occur concurrently.
+// SecurityKeyIpcServer instance to service the next request. This system
+// allows multiple security key forwarding sessions to occur concurrently.
// TODO(joedow): Update SecurityKeyAuthHandler impls to run on a separate IO
// thread instead of the thread it was created on: crbug.com/591739
class SecurityKeyAuthHandlerWin : public SecurityKeyAuthHandler {

Powered by Google App Engine
This is Rietveld 408576698