Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl

chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java

Index: chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
index ec9e4f5121adf8f6d668de6bcf80bcc650df8a36..eccef936f7a2b903e1680f0181a6c05b751d4eb4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.shapedetection;
 
 import android.content.Context;
 import android.graphics.Bitmap;
+import android.graphics.Point;
 import android.graphics.Rect;
 import android.util.SparseArray;
 
@@ -18,6 +19,7 @@ import org.chromium.blink.mojom.BarcodeDetection;
 import org.chromium.blink.mojom.BarcodeDetectionResult;
 import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;
 import org.chromium.chrome.browser.externalauth.UserRecoverableErrorHandler;
+import org.chromium.gfx.mojom.PointF;
 import org.chromium.gfx.mojom.RectF;
 import org.chromium.mojo.system.MojoException;
 import org.chromium.mojo.system.SharedBufferHandle;
@@ -35,7 +37,6 @@ public class BarcodeDetectionImpl implements BarcodeDetection {
     private BarcodeDetector mBarcodeDetector;
 
     public BarcodeDetectionImpl(Context context) {
-        Log.d(TAG, "BarcodeDetectionImpl ctor()");
         mContext = context;
         mBarcodeDetector = new BarcodeDetector.Builder(mContext).build();
     }
@@ -101,6 +102,14 @@ public class BarcodeDetectionImpl implements BarcodeDetection {
             barcodeArray[i].boundingBox.y = rect.top;
             barcodeArray[i].boundingBox.width = rect.width();
             barcodeArray[i].boundingBox.height = rect.height();
+            final Point[] corners = barcode.cornerPoints;
+            barcodeArray[i].cornerPoints = new PointF[4];
+            for (int j = 0; j < 4; j++) {

[mcasas, 2016/12/16 01:20:00]

Either make a constant for these two 4s, or
use here barcodeArray[i].cornerPoints.size().

+                barcodeArray[i].cornerPoints[j] = new PointF();
+                // |corners| starts from top-left point in clockwise direction.
+                barcodeArray[i].cornerPoints[j].x = corners[(j + 3) % 4].x;
+                barcodeArray[i].cornerPoints[j].y = corners[(j + 3) % 4].y;

[mcasas, 2016/12/16 01:20:00]

Barcode.cornerPoints [1] says:
 "4 corner points in clockwise direction starting with top-left."

and our WICG spec defines those [2] 
" in clockwise direction and starting with top-left."

They match each other, there's no need to rearrange
the points, right?

[1]
https://developers.google.com/android/reference/com/google/android/gms/vision...
[2] https://wicg.github.io/shape-detection-api/#barcode-detection-api

+            }
         }
         callback.call(barcodeArray);
     }