Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl

chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java

Index: chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
index ec9e4f5121adf8f6d668de6bcf80bcc650df8a36..735e987ed64d7c3352b4e31c8b6a66177943e262 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.shapedetection;
 
 import android.content.Context;
 import android.graphics.Bitmap;
+import android.graphics.Point;
 import android.graphics.Rect;
 import android.util.SparseArray;
 
@@ -18,6 +19,7 @@ import org.chromium.blink.mojom.BarcodeDetection;
 import org.chromium.blink.mojom.BarcodeDetectionResult;
 import org.chromium.chrome.browser.externalauth.ExternalAuthUtils;
 import org.chromium.chrome.browser.externalauth.UserRecoverableErrorHandler;
+import org.chromium.gfx.mojom.PointF;
 import org.chromium.gfx.mojom.RectF;
 import org.chromium.mojo.system.MojoException;
 import org.chromium.mojo.system.SharedBufferHandle;
@@ -35,7 +37,6 @@ public class BarcodeDetectionImpl implements BarcodeDetection {
     private BarcodeDetector mBarcodeDetector;
 
     public BarcodeDetectionImpl(Context context) {
-        Log.d(TAG, "BarcodeDetectionImpl ctor()");
         mContext = context;
         mBarcodeDetector = new BarcodeDetector.Builder(mContext).build();
     }
@@ -101,6 +102,14 @@ public class BarcodeDetectionImpl implements BarcodeDetection {
             barcodeArray[i].boundingBox.y = rect.top;
             barcodeArray[i].boundingBox.width = rect.width();
             barcodeArray[i].boundingBox.height = rect.height();
+            final Point[] corners = barcode.cornerPoints;
+            barcodeArray[i].cornerPoints = new PointF[4];
+            for (int j = 0; j < 4; j++) {
+                barcodeArray[i].cornerPoints[j] = new PointF();
+                // Point[] from Android starts from top-left corner.

[mcasas, 2016/12/15 19:01:58]

No need to say "from Android" or, in any case, you should
be more specific (like, from Barcode).
Also: ".. in clockwise orientation" (orientation is important)

[xianglu, 2016/12/16 00:01:25]

Done.

+                barcodeArray[i].cornerPoints[j].x = corners[(j + 3) % 4].x;
+                barcodeArray[i].cornerPoints[j].y = corners[(j + 3) % 4].y;
+            }
         }
         callback.call(barcodeArray);
     }