Issue 257593003: ServiceWorker: Clean up ServiceWorkerDatabase

Issue 257593003: ServiceWorker: Clean up ServiceWorkerDatabase (Closed)

Created:
6 years, 8 months ago by nhiroki

Modified:
6 years, 8 months ago

Reviewers:
michaeln, serviceworker-reviews

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ServiceWorker: Clean up ServiceWorkerDatabase BUG=364099 TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266116

Patch Set 1 : #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -50 lines)			Patch
	M	content/browser/service_worker/service_worker_database.h	View		2 chunks	+9 lines, -5 lines	0 comments	Download
	M	content/browser/service_worker/service_worker_database.cc	View		6 chunks	+50 lines, -45 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nhiroki

Hi Michael, can you take a look? This was split from the main CL (https://codereview.chromium.org/248803003/)

6 years, 8 months ago (2014-04-24 12:51:18 UTC) #1

michaeln

lgtm https://codereview.chromium.org/257593003/diff/40001/content/browser/service_worker/service_worker_database.cc File content/browser/service_worker/service_worker_database.cc (right): https://codereview.chromium.org/257593003/diff/40001/content/browser/service_worker/service_worker_database.cc#newcode208 content/browser/service_worker/service_worker_database.cc:208: db_.reset(); ok, db is closed when anything goes ...

6 years, 8 months ago (2014-04-25 00:01:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/257593003/40001

6 years, 8 months ago (2014-04-25 00:12:09 UTC) #4

Message was sent while issue was closed.

Change committed as 266116

Expand Messages | Collapse Messages