Issue 2575913002: VM: Only update hash table stats when needed for printing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2575913002: VM: Only update hash table stats when needed for printing. (Closed)

Created:
4 years ago by Florian Schneider

Modified:
4 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Only update hash table stats when needed for printing. The counters for growing and collisions are not needed otherwise. This avoid data races on concurrent reads (which would previously update the counters, even if reporting is disabled) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/017257a64f4c250bcc4cb9cb7c98b56e0902fb84

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	runtime/vm/hash_table.h	View		1 chunk	+16 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years ago (2016-12-14 18:34:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
017257a64f4c250bcc4cb9cb7c98b56e0902fb84 (presubmit successful).