Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257583005: Fix crashes in components/policy/resources/PRESUBMIT.py. (Closed)

Created:
6 years, 8 months ago by Thiemo Nagel
Modified:
6 years, 8 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy-list-doc
Visibility:
Public.

Description

Fix crashes in components/policy/resources/PRESUBMIT.py. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266099

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Move try/catch as suggested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M components/policy/resources/PRESUBMIT.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M components/policy/tools/syntax_check_policy_template_json.py View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Thiemo Nagel
Hi Joao, could you please take a look? Thank you! Thiemo
6 years, 8 months ago (2014-04-24 14:16:33 UTC) #1
Joao da Silva
https://codereview.chromium.org/257583005/diff/40001/components/policy/resources/PRESUBMIT.py File components/policy/resources/PRESUBMIT.py (right): https://codereview.chromium.org/257583005/diff/40001/components/policy/resources/PRESUBMIT.py#newcode111 components/policy/resources/PRESUBMIT.py:111: policies = _GetPolicyTemplates(template_path) I suggest you do the try/catch ...
6 years, 8 months ago (2014-04-24 14:34:49 UTC) #2
Thiemo Nagel
Thank you for your input! I've updated the CL accordingly. Could you please take another ...
6 years, 8 months ago (2014-04-24 17:16:24 UTC) #3
Joao da Silva
lgtm
6 years, 8 months ago (2014-04-24 17:45:39 UTC) #4
Thiemo Nagel
On 2014/04/24 17:45:39, Joao da Silva wrote: > lgtm Thank you!
6 years, 8 months ago (2014-04-24 17:58:08 UTC) #5
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 17:58:14 UTC) #6
Thiemo Nagel
The CQ bit was unchecked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 20:25:23 UTC) #7
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 20:25:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/257583005/60001
6 years, 8 months ago (2014-04-24 21:17:24 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 02:53:58 UTC) #10
Message was sent while issue was closed. 
Change committed as 266099

Powered by Google App Engine
This is Rietveld 408576698