Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2575743002: MD Settings: clicking on the "Learn more" shouldn't select the sync passphrase option (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 6
7 /** 7 /**
8 * Names of the radio buttons which allow the user to choose their encryption 8 * Names of the radio buttons which allow the user to choose their encryption
9 * mechanism. 9 * mechanism.
10 * @enum {string} 10 * @enum {string}
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 * @param {string} passphrase The passphrase input field value 285 * @param {string} passphrase The passphrase input field value
286 * @param {string} confirmation The passphrase confirmation input field value. 286 * @param {string} confirmation The passphrase confirmation input field value.
287 * @return {boolean} Whether the passphrase save button should be enabled. 287 * @return {boolean} Whether the passphrase save button should be enabled.
288 * @private 288 * @private
289 */ 289 */
290 isSaveNewPassphraseEnabled_: function(passphrase, confirmation) { 290 isSaveNewPassphraseEnabled_: function(passphrase, confirmation) {
291 return passphrase !== '' && confirmation !== ''; 291 return passphrase !== '' && confirmation !== '';
292 }, 292 },
293 293
294 /** 294 /**
295 * @param {!Event} e
296 * @private
297 */
298 onSyncLearnMoreTap_: function(e) {
299 e.stopPropagation();
300 },
301
302 /**
295 * Sends the newly created custom sync passphrase to the browser. 303 * Sends the newly created custom sync passphrase to the browser.
296 * @private 304 * @private
297 */ 305 */
298 onSaveNewPassphraseTap_: function() { 306 onSaveNewPassphraseTap_: function() {
299 assert(this.creatingNewPassphrase_); 307 assert(this.creatingNewPassphrase_);
300 308
301 // If a new password has been entered but it is invalid, do not send the 309 // If a new password has been entered but it is invalid, do not send the
302 // sync state to the API. 310 // sync state to the API.
303 if (!this.validateCreatedPassphrases_()) 311 if (!this.validateCreatedPassphrases_())
304 return; 312 return;
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 * @private 434 * @private
427 */ 435 */
428 onLearnMoreTap_: function(event) { 436 onLearnMoreTap_: function(event) {
429 // Stop the propagation of events, so that clicking on links inside 437 // Stop the propagation of events, so that clicking on links inside
430 // checkbox labels won't change the checkbox value. 438 // checkbox labels won't change the checkbox value.
431 event.stopPropagation(); 439 event.stopPropagation();
432 } 440 }
433 }); 441 });
434 442
435 })(); 443 })();
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698