Issue 257573002: Oilpan: Fix crash in content::WebIDBCursorImpl::~WebIDBCursorImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257573002: Oilpan: Fix crash in content::WebIDBCursorImpl::~WebIDBCursorImpl. (Closed)

Created:
6 years, 8 months ago by tkent

Modified:
6 years, 8 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Fix crash in content::WebIDBCursorImpl::~WebIDBCursorImpl. Our assumption is WebIDBCursorImpl objects are destructed before the WorkerRunLoop for the owner Worker is stopped. In Oilpan, IDB objects can outlive the runloop. So we explicitly delete WebIDBCursor owned by IDBCursor on ActiveDOMObject::stop. BUG=366530 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172568

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	Source/modules/indexeddb/IDBAny.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/indexeddb/IDBAny.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/modules/indexeddb/IDBCursor.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequest.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

Please review this. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showExpectations=true&showLargeExpectations=true&tests=storage%2Findexeddb%2Fcursor-advance.html

6 years, 8 months ago (2014-04-24 09:35:49 UTC) #1

haraken

LGTM Another fix was here: https://codereview.chromium.org/218953002/ but this fix looks much better than mine.

6 years, 8 months ago (2014-04-24 10:36:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/257573002/1

6 years, 8 months ago (2014-04-24 22:21:05 UTC) #5

Message was sent while issue was closed.

Change committed as 172568

Expand Messages | Collapse Messages