Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 2575723002: DevTools: violation warnings pop up in sources while debugging (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 if (message.url) 98 if (message.url)
99 return debuggerModel.createRawLocationByURL(message.url, message.line, mes sage.column); 99 return debuggerModel.createRawLocationByURL(message.url, message.line, mes sage.column);
100 return null; 100 return null;
101 } 101 }
102 102
103 /** 103 /**
104 * @param {!SDK.ConsoleMessage} message 104 * @param {!SDK.ConsoleMessage} message
105 * @param {!SDK.DebuggerModel.Location} rawLocation 105 * @param {!SDK.DebuggerModel.Location} rawLocation
106 */ 106 */
107 _addConsoleMessageToScript(message, rawLocation) { 107 _addConsoleMessageToScript(message, rawLocation) {
108 if (message.source === SDK.ConsoleMessage.MessageSource.Violation)
109 return;
108 this._presentationConsoleMessages.push( 110 this._presentationConsoleMessages.push(
109 new Bindings.PresentationConsoleMessage(message, rawLocation, this._loca tionPool)); 111 new Bindings.PresentationConsoleMessage(message, rawLocation, this._loca tionPool));
110 } 112 }
111 113
112 /** 114 /**
113 * @param {!SDK.ConsoleMessage} message 115 * @param {!SDK.ConsoleMessage} message
114 */ 116 */
115 _addPendingConsoleMessage(message) { 117 _addPendingConsoleMessage(message) {
116 if (!message.url) 118 if (!message.url)
117 return; 119 return;
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 } 194 }
193 195
194 dispose() { 196 dispose() {
195 if (this._uiMessage) 197 if (this._uiMessage)
196 this._uiMessage.remove(); 198 this._uiMessage.remove();
197 } 199 }
198 }; 200 };
199 201
200 /** @type {!Bindings.PresentationConsoleMessageHelper} */ 202 /** @type {!Bindings.PresentationConsoleMessageHelper} */
201 Bindings.presentationConsoleMessageHelper; 203 Bindings.presentationConsoleMessageHelper;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698