Issue 25757007: V2: Implement reparenting, bounds and visibility change notifications, and write more tests.

Issue 25757007: V2: Implement reparenting, bounds and visibility change notifications, and write more tests. (Closed)

Created:
7 years, 2 months ago by Ben Goodger (Google)

Modified:
7 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

V2: Implement reparenting, bounds and visibility change notifications, and write more tests. TBR=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226847

Patch Set 2 : . #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+312 lines, -59 lines)			Patch
M	ui/v2/public/view.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/v2/public/view_observer.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	ui/v2/src/layout.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/v2/src/view.cc	View		8 chunks	+51 lines, -46 lines	0 comments	Download
A	ui/v2/src/view_private.h	View	1	1 chunk	+40 lines, -0 lines	1 comment	Download
A +	ui/v2/src/view_private.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/v2/src/view_unittest.cc	View		4 chunks	+204 lines, -0 lines	0 comments	Download
M	ui/v2/v2.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Committed patchset #2 manually as r226847 (presubmit successful).

7 years, 2 months ago (2013-10-03 21:12:48 UTC) #2

sky

LGTM https://codereview.chromium.org/25757007/diff/3001/ui/v2/src/view_private.h File ui/v2/src/view_private.h (right): https://codereview.chromium.org/25757007/diff/3001/ui/v2/src/view_private.h#newcode21 ui/v2/src/view_private.h:21: class ViewPrivate { One disadvantage of this approach ...

7 years, 2 months ago (2013-10-03 21:28:19 UTC) #3

Ben Goodger (Google)

7 years, 2 months ago (2013-10-03 21:46:50 UTC) #4

Good point, I'll think about this more once I get to making Layout work.

-Ben


On Thu, Oct 3, 2013 at 2:28 PM, <sky@chromium.org> wrote:

> LGTM
>
>
> https://codereview.chromium.**org/25757007/diff/3001/ui/v2/**
>
src/view_private.h<https://codereview.chromium.org/25757007/diff/3001/ui/v2/src/view_private.h>
> File ui/v2/src/view_private.h (right):
>
> https://codereview.chromium.**org/25757007/diff/3001/ui/v2/**
>
src/view_private.h#newcode21<https://codereview.chromium.org/25757007/diff/3001/ui/v2/src/view_private.h#newcode21>
> ui/v2/src/view_private.h:21: class ViewPrivate {
> One disadvantage of this approach vs what we have in aura::LayoutManager
> is that in theory anyone can create a ViewPrivate. The
> aura::LayoutManager constrains the private interface to only those who
> need it.
>
>
https://codereview.chromium.**org/25757007/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages