Issue 25757002: Refactor calculation of variables, common to many generators.

Issue 25757002: Refactor calculation of variables, common to many generators. (Closed)

Created:
7 years, 2 months ago by Slava Chigrin

Modified:
7 years, 2 months ago

Reviewers:
Nico, scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Refactor calculation of variables, common to many generators. Patch by Slava Chigrin <vchigrin@yandex-team.ru>;. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1747

Patch Set 2 : Fix indentation. #

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -40 lines)			Patch
M	pylib/gyp/generator/dump_dependency_json.py	View	1 2	1 chunk	+1 line, -13 lines	0 comments	Download
M	pylib/gyp/generator/eclipse.py	View	1 2	1 chunk	+1 line, -13 lines	0 comments	Download
M	pylib/gyp/generator/ninja.py	View	1 2	2 chunks	+1 line, -14 lines	0 comments	Download
M	pylib/gyp/msvs_emulation.py	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Slava Chigrin

Some little refactoring, as were agreed in https://codereview.chromium.org/23606009/

7 years, 2 months ago (2013-10-02 16:55:48 UTC) #1

scottmg

lgtm with fix below. https://codereview.chromium.org/25757002/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://codereview.chromium.org/25757002/diff/1/pylib/gyp/msvs_emulation.py#newcode855 pylib/gyp/msvs_emulation.py:855: generator_flags = params.get('generator_flags', {}) 2-space ...

7 years, 2 months ago (2013-10-02 16:57:42 UTC) #2

Slava Chigrin

Done, sorry that I forgot to adjust my editor indentation preferences. https://codereview.chromium.org/25757002/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): ...

7 years, 2 months ago (2013-10-03 07:32:28 UTC) #3

scottmg

On 2013/10/03 07:32:28, Slava Chigrin wrote: > Done, sorry that I forgot to adjust my ...

7 years, 2 months ago (2013-10-03 17:55:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r1747.

Expand Messages | Collapse Messages