Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 257563006: use BenchTimer, print in µs (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

use BenchTimer, print in µs BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14405

Patch Set 1 #

Patch Set 2 : stray u #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M gyp/bench.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M gyp/tools.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/bench_playback.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M tools/bench_record.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
"Why aren't we using BenchTimer here?" Because I thought it was a lot more complicated ...
6 years, 8 months ago (2014-04-24 21:42:17 UTC) #1
mtklein
lgtm
6 years, 7 months ago (2014-04-28 15:10:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/257563006/20001
6 years, 7 months ago (2014-04-28 15:11:04 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 15:30:04 UTC) #4
Message was sent while issue was closed.
Change committed as 14405

Powered by Google App Engine
This is Rietveld 408576698