src/mips/full-codegen-mips.cc - Issue 257563004: Unify and simplify the FastCloneShallowArrayStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/full-codegen-mips.cc

Issue 257563004: Unify and simplify the FastCloneShallowArrayStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix arm64 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/full-codegen-mips.cc

diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc

index 1466af61c58616f708459837fe677fb0b661f2da..9f4c670957b4d22dc004838f654197cc54ef876b 100644

--- a/src/mips/full-codegen-mips.cc

+++ b/src/mips/full-codegen-mips.cc

@@ -1842,7 +1842,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

__ IncrementCounter(isolate()->counters()->cow_arrays_created_stub(),

1, a1, a2);

} else if (expr->depth() > 1 || Serializer::enabled() ||

- length > FastCloneShallowArrayStub::kMaximumClonedLength) {

+ length > FastCloneShallowArrayStub::kMaximumInlinedCloneLength) {

__ li(a0, Operand(Smi::FromInt(flags)));

__ Push(a3, a2, a1, a0);

__ CallRuntime(Runtime::kHiddenCreateArrayLiteral, 4);