Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/arm64/code-stubs-arm64.cc

Issue 257563004: Unify and simplify the FastCloneShallowArrayStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 82
83 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor( 83 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor(
84 CodeStubInterfaceDescriptor* descriptor) { 84 CodeStubInterfaceDescriptor* descriptor) {
85 // x3: array literals array 85 // x3: array literals array
86 // x2: array literal index 86 // x2: array literal index
87 // x1: constant elements 87 // x1: constant elements
88 static Register registers[] = { x3, x2, x1 }; 88 static Register registers[] = { x3, x2, x1 };
89 descriptor->register_param_count_ = sizeof(registers) / sizeof(registers[0]); 89 descriptor->register_param_count_ = sizeof(registers) / sizeof(registers[0]);
90 descriptor->register_params_ = registers; 90 descriptor->register_params_ = registers;
91 static Representation representations[] = {
92 Representation::Tagged(),
93 Representation::Smi(),
94 Representation::Tagged() };
95 descriptor->register_param_representations_ = representations;
91 descriptor->deoptimization_handler_ = 96 descriptor->deoptimization_handler_ =
92 Runtime::FunctionForId( 97 Runtime::FunctionForId(
93 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry; 98 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry;
94 } 99 }
95 100
96 101
97 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor( 102 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor(
98 CodeStubInterfaceDescriptor* descriptor) { 103 CodeStubInterfaceDescriptor* descriptor) {
99 // x3: object literals array 104 // x3: object literals array
100 // x2: object literal index 105 // x2: object literal index
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 descriptor->register_param_count_ = 251 descriptor->register_param_count_ =
247 sizeof(registers_no_args) / sizeof(registers_no_args[0]); 252 sizeof(registers_no_args) / sizeof(registers_no_args[0]);
248 descriptor->register_params_ = registers_no_args; 253 descriptor->register_params_ = registers_no_args;
249 } else { 254 } else {
250 // stack param count needs (constructor pointer, and single argument) 255 // stack param count needs (constructor pointer, and single argument)
251 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 256 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
252 descriptor->stack_parameter_count_ = x0; 257 descriptor->stack_parameter_count_ = x0;
253 descriptor->register_param_count_ = 258 descriptor->register_param_count_ =
254 sizeof(registers_variable_args) / sizeof(registers_variable_args[0]); 259 sizeof(registers_variable_args) / sizeof(registers_variable_args[0]);
255 descriptor->register_params_ = registers_variable_args; 260 descriptor->register_params_ = registers_variable_args;
261 static Representation representations[] = {
262 Representation::Tagged(),
263 Representation::Tagged(),
264 Representation::Integer32() };
265 descriptor->register_param_representations_ = representations;
256 } 266 }
257 267
258 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 268 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
259 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 269 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
260 descriptor->deoptimization_handler_ = 270 descriptor->deoptimization_handler_ =
261 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry; 271 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry;
262 } 272 }
263 273
264 274
265 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor( 275 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor(
(...skipping 26 matching lines...) Expand all
292 descriptor->register_param_count_ = 302 descriptor->register_param_count_ =
293 sizeof(registers_no_args) / sizeof(registers_no_args[0]); 303 sizeof(registers_no_args) / sizeof(registers_no_args[0]);
294 descriptor->register_params_ = registers_no_args; 304 descriptor->register_params_ = registers_no_args;
295 } else { 305 } else {
296 // stack param count needs (constructor pointer, and single argument) 306 // stack param count needs (constructor pointer, and single argument)
297 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 307 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
298 descriptor->stack_parameter_count_ = x0; 308 descriptor->stack_parameter_count_ = x0;
299 descriptor->register_param_count_ = 309 descriptor->register_param_count_ =
300 sizeof(registers_variable_args) / sizeof(registers_variable_args[0]); 310 sizeof(registers_variable_args) / sizeof(registers_variable_args[0]);
301 descriptor->register_params_ = registers_variable_args; 311 descriptor->register_params_ = registers_variable_args;
312 static Representation representations[] = {
313 Representation::Tagged(),
314 Representation::Integer32() };
315 descriptor->register_param_representations_ = representations;
302 } 316 }
303 317
304 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 318 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
305 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 319 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
306 descriptor->deoptimization_handler_ = 320 descriptor->deoptimization_handler_ =
307 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry; 321 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry;
308 } 322 }
309 323
310 324
311 void InternalArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor( 325 void InternalArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor(
(...skipping 5072 matching lines...) Expand 10 before | Expand all | Expand 10 after
5384 MemOperand(fp, 6 * kPointerSize), 5398 MemOperand(fp, 6 * kPointerSize),
5385 NULL); 5399 NULL);
5386 } 5400 }
5387 5401
5388 5402
5389 #undef __ 5403 #undef __
5390 5404
5391 } } // namespace v8::internal 5405 } } // namespace v8::internal
5392 5406
5393 #endif // V8_TARGET_ARCH_ARM64 5407 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698