Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 257563004: Unify and simplify the FastCloneShallowArrayStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix arm64 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | src/hydrogen.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 Runtime::FunctionForId(Runtime::kHiddenNumberToString)->entry; 79 Runtime::FunctionForId(Runtime::kHiddenNumberToString)->entry;
80 } 80 }
81 81
82 82
83 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor( 83 void FastCloneShallowArrayStub::InitializeInterfaceDescriptor(
84 Isolate* isolate, 84 Isolate* isolate,
85 CodeStubInterfaceDescriptor* descriptor) { 85 CodeStubInterfaceDescriptor* descriptor) {
86 static Register registers[] = { r3, r2, r1 }; 86 static Register registers[] = { r3, r2, r1 };
87 descriptor->register_param_count_ = 3; 87 descriptor->register_param_count_ = 3;
88 descriptor->register_params_ = registers; 88 descriptor->register_params_ = registers;
89 static Representation representations[] = {
90 Representation::Tagged(),
91 Representation::Smi(),
92 Representation::Tagged() };
93 descriptor->register_param_representations_ = representations;
89 descriptor->deoptimization_handler_ = 94 descriptor->deoptimization_handler_ =
90 Runtime::FunctionForId( 95 Runtime::FunctionForId(
91 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry; 96 Runtime::kHiddenCreateArrayLiteralStubBailout)->entry;
92 } 97 }
93 98
94 99
95 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor( 100 void FastCloneShallowObjectStub::InitializeInterfaceDescriptor(
96 Isolate* isolate, 101 Isolate* isolate,
97 CodeStubInterfaceDescriptor* descriptor) { 102 CodeStubInterfaceDescriptor* descriptor) {
98 static Register registers[] = { r3, r2, r1, r0 }; 103 static Register registers[] = { r3, r2, r1, r0 };
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 240
236 if (constant_stack_parameter_count == 0) { 241 if (constant_stack_parameter_count == 0) {
237 descriptor->register_param_count_ = 2; 242 descriptor->register_param_count_ = 2;
238 descriptor->register_params_ = registers_no_args; 243 descriptor->register_params_ = registers_no_args;
239 } else { 244 } else {
240 // stack param count needs (constructor pointer, and single argument) 245 // stack param count needs (constructor pointer, and single argument)
241 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 246 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
242 descriptor->stack_parameter_count_ = r0; 247 descriptor->stack_parameter_count_ = r0;
243 descriptor->register_param_count_ = 3; 248 descriptor->register_param_count_ = 3;
244 descriptor->register_params_ = registers_variable_args; 249 descriptor->register_params_ = registers_variable_args;
250 static Representation representations[] = {
251 Representation::Tagged(),
252 Representation::Tagged(),
253 Representation::Integer32() };
254 descriptor->register_param_representations_ = representations;
245 } 255 }
246 256
247 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 257 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
248 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 258 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
249 descriptor->deoptimization_handler_ = 259 descriptor->deoptimization_handler_ =
250 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry; 260 Runtime::FunctionForId(Runtime::kHiddenArrayConstructor)->entry;
251 } 261 }
252 262
253 263
254 static void InitializeInternalArrayConstructorDescriptor( 264 static void InitializeInternalArrayConstructorDescriptor(
255 Isolate* isolate, 265 Isolate* isolate,
256 CodeStubInterfaceDescriptor* descriptor, 266 CodeStubInterfaceDescriptor* descriptor,
257 int constant_stack_parameter_count) { 267 int constant_stack_parameter_count) {
258 // register state 268 // register state
259 // r0 -- number of arguments 269 // r0 -- number of arguments
260 // r1 -- constructor function 270 // r1 -- constructor function
261 static Register registers_variable_args[] = { r1, r0 }; 271 static Register registers_variable_args[] = { r1, r0 };
262 static Register registers_no_args[] = { r1 }; 272 static Register registers_no_args[] = { r1 };
263 273
264 if (constant_stack_parameter_count == 0) { 274 if (constant_stack_parameter_count == 0) {
265 descriptor->register_param_count_ = 1; 275 descriptor->register_param_count_ = 1;
266 descriptor->register_params_ = registers_no_args; 276 descriptor->register_params_ = registers_no_args;
267 } else { 277 } else {
268 // stack param count needs (constructor pointer, and single argument) 278 // stack param count needs (constructor pointer, and single argument)
269 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS; 279 descriptor->handler_arguments_mode_ = PASS_ARGUMENTS;
270 descriptor->stack_parameter_count_ = r0; 280 descriptor->stack_parameter_count_ = r0;
271 descriptor->register_param_count_ = 2; 281 descriptor->register_param_count_ = 2;
272 descriptor->register_params_ = registers_variable_args; 282 descriptor->register_params_ = registers_variable_args;
283 static Representation representations[] = {
284 Representation::Tagged(),
285 Representation::Integer32() };
286 descriptor->register_param_representations_ = representations;
273 } 287 }
274 288
275 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count; 289 descriptor->hint_stack_parameter_count_ = constant_stack_parameter_count;
276 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE; 290 descriptor->function_mode_ = JS_FUNCTION_STUB_MODE;
277 descriptor->deoptimization_handler_ = 291 descriptor->deoptimization_handler_ =
278 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry; 292 Runtime::FunctionForId(Runtime::kHiddenInternalArrayConstructor)->entry;
279 } 293 }
280 294
281 295
282 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor( 296 void ArrayNoArgumentConstructorStub::InitializeInterfaceDescriptor(
(...skipping 4907 matching lines...) Expand 10 before | Expand all | Expand 10 after
5190 MemOperand(fp, 6 * kPointerSize), 5204 MemOperand(fp, 6 * kPointerSize),
5191 NULL); 5205 NULL);
5192 } 5206 }
5193 5207
5194 5208
5195 #undef __ 5209 #undef __
5196 5210
5197 } } // namespace v8::internal 5211 } } // namespace v8::internal
5198 5212
5199 #endif // V8_TARGET_ARCH_ARM 5213 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/full-codegen-arm.cc » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698