Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: components/security_interstitials/core/controller_client.h

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)
Patch Set: nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 5e4595902b4fa8f8445d0ff648ab5fd9728321bb..8acbf35458d2165ac36d1044e76b0cb1bc7dd179 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -68,9 +68,15 @@ class ControllerClient {
virtual bool CanLaunchDateAndTimeSettings() = 0;
virtual void LaunchDateAndTimeSettings() = 0;
- // Close the error and go back to the previous page.
+ // Close the error and go back to the previous page. This applies to
+ // situations where navigation is blocked before committing.
virtual void GoBack() = 0;
+ // If the offending entry has committed, go back or to a safe page without
+ // closing the error page. This error page will be closed when the new page
+ // commits.
+ virtual void GoBackAfterNavigationCommitted() = 0;
+
// Close the error and proceed to the blocked page.
virtual void Proceed() = 0;

Powered by Google App Engine
This is Rietveld 408576698