Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/interstitials/chrome_metrics_helper.cc

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)
Patch Set: nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/interstitials/chrome_metrics_helper.h ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | components/security_interstitials/core/safe_browsing_error_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/interstitials/chrome_metrics_helper.cc
diff --git a/chrome/browser/interstitials/chrome_metrics_helper.cc b/chrome/browser/interstitials/chrome_metrics_helper.cc
index 98dda57ce45dabdfb794d8dd14ac4a539593470f..860c919d1a656acf63a5a0875484d59d5dd40515 100644
--- a/chrome/browser/interstitials/chrome_metrics_helper.cc
+++ b/chrome/browser/interstitials/chrome_metrics_helper.cc
@@ -9,7 +9,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/features.h"
#include "components/history/core/browser/history_service.h"
-#include "components/rappor/rappor_service_impl.h"
#include "content/public/browser/web_contents.h"
#include "extensions/features/features.h"
@@ -31,10 +30,7 @@ ChromeMetricsHelper::ChromeMetricsHelper(
settings,
HistoryServiceFactory::GetForProfile(
Profile::FromBrowserContext(web_contents->GetBrowserContext()),
- ServiceAccessType::EXPLICIT_ACCESS),
- g_browser_process->rappor_service()
- ? g_browser_process->rappor_service()->AsWeakPtr()
- : base::WeakPtr<rappor::RapporService>()),
+ ServiceAccessType::EXPLICIT_ACCESS)),
#if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION) || BUILDFLAG(ENABLE_EXTENSIONS)
web_contents_(web_contents),
#endif
« chrome/browser/interstitials/chrome_controller_client.cc ('K') | « chrome/browser/interstitials/chrome_metrics_helper.h ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | components/security_interstitials/core/safe_browsing_error_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698