Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5280)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)
Patch Set: address comments from nparker@ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.cc ('k') | components/security_interstitials/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 12641f2571d4df47a5e250dcd275f112b26a40fd..e94a43b55b2ad8d3141049dea0f6cdc31e65ba26 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -58,11 +58,6 @@ enum SSLExpirationAndDecision {
END_OF_SSL_EXPIRATION_AND_DECISION,
};
-// Rappor prefix, which is used for both overridable and non-overridable
-// interstitials so we don't leak the "overridable" bit.
-const char kDeprecatedSSLRapporPrefix[] = "ssl2";
-const char kSSLRapporPrefix[] = "ssl3";
-
std::string GetSamplingEventName(const bool overridable, const int cert_error) {
std::string event_name(kEventNameBase);
if (overridable)
@@ -108,10 +103,6 @@ std::unique_ptr<ChromeMetricsHelper> CreateMetricsHelper(
security_interstitials::MetricsHelper::ReportDetails reporting_info;
reporting_info.metric_prefix =
overridable ? "ssl_overridable" : "ssl_nonoverridable";
- reporting_info.rappor_prefix = kSSLRapporPrefix;
- reporting_info.deprecated_rappor_prefix = kDeprecatedSSLRapporPrefix;
- reporting_info.rappor_report_type = rappor::LOW_FREQUENCY_UMA_RAPPOR_TYPE;
- reporting_info.deprecated_rappor_report_type = rappor::UMA_RAPPOR_TYPE;
return base::MakeUnique<ChromeMetricsHelper>(
web_contents, request_url, reporting_info,
GetSamplingEventName(overridable, cert_error));
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.cc ('k') | components/security_interstitials/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698