components/security_interstitials/core/BUILD.gn - Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_interstitials/core/BUILD.gn

Issue 2575623002: Componentizing SafeBrowsingBlockingPage Part 1 (Closed)

Patch Set: address comments from estark@ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ssl/cert_report_helper.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.cc ('k') | components/security_interstitials/core/controller_client.h » ('j') | components/security_interstitials/core/metrics_helper.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("core") {	5 static_library("core") {

6 sources = [	6 sources = [

7 "bad_clock_ui.cc",	7 "bad_clock_ui.cc",

8 "bad_clock_ui.h",	8 "bad_clock_ui.h",

9 "common_string_util.cc",	9 "common_string_util.cc",

10 "common_string_util.h",	10 "common_string_util.h",

11 "controller_client.cc",	11 "controller_client.cc",

12 "controller_client.h",	12 "controller_client.h",

13 "metrics_helper.cc",	13 "metrics_helper.cc",

14 "metrics_helper.h",	14 "metrics_helper.h",

	15 "safe_browsing_error_ui.cc",

	16 "safe_browsing_error_ui.h",

15 "ssl_error_ui.cc",	17 "ssl_error_ui.cc",

16 "ssl_error_ui.h",	18 "ssl_error_ui.h",

17 ]	19 ]

18	20

19 deps = [	21 deps = [

20 "//base",	22 "//base",

21 "//base:i18n",	23 "//base:i18n",

22 "//components/google/core/browser",	24 "//components/google/core/browser",

23 "//components/history/core/browser",	25 "//components/history/core/browser",

24 "//components/metrics",	26 "//components/metrics",

25 "//components/prefs",	27 "//components/prefs",

26 "//components/rappor",	28 "//components/rappor",
	Nathan Parker 2016/12/15 23:30:42 Can we remove rappor here? Can we remove rappor here? Jialiu Lin 2016/12/16 00:51:42 Yes. Done. Show quoted text On 2016/12/15 23:30:42, Nathan Parker wrote: > Can we remove rappor here? Yes. Done.
27 "//components/ssl_errors",	29 "//components/ssl_errors",

28 "//components/strings",	30 "//components/strings",

29 "//components/url_formatter",	31 "//components/url_formatter",

30 "//net",	32 "//net",

31 "//ui/base",	33 "//ui/base",

32 ]	34 ]

33 }	35 }

OLD	NEW