chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc - Issue 2575613002: Remove ShelfItemDelegate::IsDraggable; check for app list button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

Issue 2575613002: Remove ShelfItemDelegate::IsDraggable; check for app list button. (Closed)

Patch Set: Address comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h ('k') | chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

index 203c95661d3517ae8f5e279a593bf15bcd909b24..0f62d9a6fb21b27f6bc3faf7a441191da27b1831 100644

--- a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

@@ -220,10 +220,6 @@ ash::ShelfMenuModel* AppShortcutLauncherItemController::CreateApplicationMenu(

return new LauncherApplicationMenuItemModel(GetApplicationList(event_flags));

}

-bool AppShortcutLauncherItemController::IsDraggable() {

- return true;

bool AppShortcutLauncherItemController::CanPin() const {

return GetPinnableForAppID(app_id(), launcher_controller()->profile()) ==

AppListControllerDelegate::PIN_EDITABLE;