ash/common/shelf/shelf_controller.cc - Issue 2575613002: Remove ShelfItemDelegate::IsDraggable; check for app list button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_controller.cc

Issue 2575613002: Remove ShelfItemDelegate::IsDraggable; check for app list button. (Closed)

Patch Set: Address comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_controller.cc

diff --git a/ash/common/shelf/shelf_controller.cc b/ash/common/shelf/shelf_controller.cc

index ecc96e2acc0fe026b9d6a232905eef48fe3b42f0..a027b98c3d388753d1128b31b125012c7ae8f3aa 100644

--- a/ash/common/shelf/shelf_controller.cc

+++ b/ash/common/shelf/shelf_controller.cc

@@ -114,11 +114,6 @@ class ShelfItemDelegateMus : public ShelfItemDelegate {

return new ShelfMenuModelMus(this);

}

- bool IsDraggable() override {

- NOTIMPLEMENTED();

- return false;

- }

void Close() override { NOTIMPLEMENTED(); }

mojom::ShelfItemDelegateAssociatedPtr delegate_;