Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_unittest.cc

Issue 25756003: Disable TabStripModelTest.FastShutdown on Mac 64. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tabs/tab_strip_model_unittest.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
index e6621637db3379ca9f0c5dc58d9102f348560718..2583f3028eccc214ec1596750a859c2fb023b1b4 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
@@ -1709,8 +1709,9 @@ TEST_F(TabStripModelTest, NavigationForgettingDoesntAffectNewTab) {
strip.CloseAllTabs();
}
-// This fails on linux when run with the rest of unit_tests (crbug.com/302156).
-#if defined(OS_LINUX)
+// This fails on Linux when run with the rest of unit_tests (crbug.com/302156)
+// and fails consistently on Mac 64.
+#if defined(OS_LINUX) || (defined(OS_MACOSX) && ARCH_CPU_64_BITS)
#define MAYBE_FastShutdown \
Nico 2013/10/02 18:22:17 Just disable it for all platforms maybe?
Avi (use Gerrit) 2013/10/02 18:25:31 I feel really awkward killing tests.
DISABLED_FastShutdown
#else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698