Disable TabStripModelTest.FastShutdown on Mac 64.

Disable TabStripModelTest.FastShutdown on Mac 64.

BUG=302156
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226507

[Avi (use Gerrit), 2013-10-02 18:14:21]

Nico, this test started failing on Mac 64 consistently in the past day, and if
you look at the bug it's failing on all platforms. Disabling on Mac 64 to let
the experts fix.

[Nico, 2013-10-02 18:22:16]

lgtm

https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_st...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_st...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:1715: #define
MAYBE_FastShutdown \
Just disable it for all platforms maybe?

[Avi (use Gerrit), 2013-10-02 18:25:31]

https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_st...
File chrome/browser/ui/tabs/tab_strip_model_unittest.cc (right):

https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_st...
chrome/browser/ui/tabs/tab_strip_model_unittest.cc:1715: #define
MAYBE_FastShutdown \
On 2013/10/02 18:22:17, Nico wrote:
> Just disable it for all platforms maybe?

I feel really awkward killing tests.

[commit-bot: I haz the power, 2013-10-02 18:26:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/25756003/1

[Avi (use Gerrit), 2013-10-02 18:30:49]

Committed patchset #1 manually as r226507 (presubmit successful).

[Nico, 2013-10-02 18:31:22]

On Wed, Oct 2, 2013 at 11:25 AM, <avi@chromium.org> wrote:

>
> https://codereview.chromium.**org/25756003/diff/1/chrome/**
>
browser/ui/tabs/tab_strip_**model_unittest.cc<https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_strip_model_unittest.cc>
> File chrome/browser/ui/tabs/tab_**strip_model_unittest.cc (right):
>
> https://codereview.chromium.**org/25756003/diff/1/chrome/**
>
browser/ui/tabs/tab_strip_**model_unittest.cc#newcode1715<https://codereview.chromium.org/25756003/diff/1/chrome/browser/ui/tabs/tab_strip_model_unittest.cc#newcode1715>
> chrome/browser/ui/tabs/tab_**strip_model_unittest.cc:1715: #define
> MAYBE_FastShutdown \
> On 2013/10/02 18:22:17, Nico wrote:
>
>> Just disable it for all platforms maybe?
>>
>
> I feel really awkward killing tests.
>

You're saying it's broken everywhere, so it should be disabled everywhere


>
>
https://codereview.chromium.**org/25756003/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Avi (use Gerrit), 2013-10-02 18:35:22]

On 2013/10/02 18:31:22, Nico wrote:
> You're saying it's broken everywhere, so it should be disabled everywhere

Everywhere meaning all platforms, not all the time. If it passes on some
platforms I don't feel comfortable disabling it there.