Getting rid of frame_size_in_dip in Layer::SetShowSurface

ui/compositor/layer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_COMPOSITOR_LAYER_H_
 #define UI_COMPOSITOR_LAYER_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 278 matching lines @@
       std::unique_ptr<cc::SingleReleaseCallback> release_callback,
       gfx::Size texture_size_in_dip);
   void SetTextureSize(gfx::Size texture_size_in_dip);
   void SetTextureFlipped(bool flipped);
   bool TextureFlipped() const;
 
   // Begins showing content from a surface with a particular id.
   void SetShowSurface(const cc::SurfaceId& surface_id,
                       const cc::SurfaceLayer::SatisfyCallback& satisfy_callback,
                       const cc::SurfaceLayer::RequireCallback& require_callback,
                       gfx::Size surface_size,

[sadrul, 2016/12/14 01:06:25]

Can you rename this to be |surface_size_in_pixels| to make it obvious that this
is not in DIP?

[Fady Samuel, 2016/12/14 01:11:44]

While you're at it, we tend to prefer pass by const ref for non-primitive types.

const gfx::Size& surface_size_in_pixels

[Saman Sami, 2016/12/14 01:28:02]

Done.

-                      float scale,
-                      gfx::Size frame_size_in_dip);
+                      float scale);
 
   bool has_external_content() {
     return texture_layer_.get() || surface_layer_.get();
   }
 
   // Show a solid color instead of delegated or surface contents.
   void SetShowSolidColorContent();
 
   // Sets the layer's fill color.  May only be called for LAYER_SOLID_COLOR.
   void SetColor(SkColor color);
@@ skipping 225 matching lines @@
   // The size of the frame or texture in DIP, set when SetShowDelegatedContent
   // or SetTextureMailbox was called.
   gfx::Size frame_size_in_dip_;
 
   DISALLOW_COPY_AND_ASSIGN(Layer);
 };
 
 }  // namespace ui
 
 #endif  // UI_COMPOSITOR_LAYER_H_