Getting rid of frame_size_in_dip in Layer::SetShowSurface

components/exo/surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/surface.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
@@ skipping 405 matching lines @@
     // the layer may be mirrored, in which case a surface change causes the
     // mirror layer to update its surface using the latest bounds.
     window_->layer()->SetBounds(
         gfx::Rect(window_->layer()->bounds().origin(), content_size_));
     window_->layer()->SetShowSurface(
         cc::SurfaceId(frame_sink_id_, local_frame_id_),
         base::Bind(&CompositorFrameSinkHolder::Satisfy,
                    compositor_frame_sink_holder_),
         base::Bind(&CompositorFrameSinkHolder::Require,
                    compositor_frame_sink_holder_),
-        content_size_, contents_surface_to_layer_scale, content_size_);
+        content_size_, contents_surface_to_layer_scale);

[Fady Samuel, 2016/12/14 00:33:16]

Doesn't this mean we're changing behavior? Both DIPS and physical pixels are the
same? That's very weird.

[Saman Sami, 2016/12/14 00:39:46]

The scale is always one (see line 414), so it's fine.

     window_->layer()->SetFillsBoundsOpaquely(
         state_.blend_mode == SkBlendMode::kSrc ||
         state_.opaque_region.contains(
             gfx::RectToSkIRect(gfx::Rect(content_size_))));
   }
 
   // Reset damage.
   pending_damage_.setEmpty();
 
   DCHECK(!current_resource_.id ||
@@ skipping 328 matching lines @@
 
 int64_t Surface::GetPropertyInternal(const void* key,
                                      int64_t default_value) const {
   std::map<const void*, Value>::const_iterator iter = prop_map_.find(key);
   if (iter == prop_map_.end())
     return default_value;
   return iter->second.value;
 }
 
 }  // namespace exo