Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 25755002: Unify and fix checkers for duplicate object literal properties. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Unify and fix checkers for duplicate object literal properties. R=ulan@chromium.org TEST=preparser/duplicate-property Committed: http://code.google.com/p/v8/source/detail?r=17114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -361 lines) Patch
M src/conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/parser.cc View 7 chunks +14 lines, -89 lines 0 comments Download
M src/preparser.h View 5 chunks +94 lines, -88 lines 0 comments Download
M src/preparser.cc View 5 chunks +10 lines, -176 lines 0 comments Download
M src/scanner.h View 3 chunks +54 lines, -1 line 0 comments Download
M src/scanner.cc View 2 chunks +140 lines, -0 lines 0 comments Download
M test/preparser/preparser.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 2 months ago (2013-10-02 16:52:23 UTC) #1
ulan
LGTM
7 years, 2 months ago (2013-10-04 14:01:29 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-10-04 16:58:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698