Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: src/interpreter/interpreter.cc

Issue 2575473002: [interpreter][stubs] Enable graph verification for bytecode handlers and stubs included into snapsh… (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | test/cctest/compiler/code-assembler-tester.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index d1fb8bc5ad5383770886f8a4f3985cb324a20cdd..b6716b344291a8065044976bacdeb6cd279be570 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -104,7 +104,11 @@ void Interpreter::InstallBytecodeHandler(Zone* zone, Bytecode bytecode,
Bytecodes::ToString(bytecode), Bytecodes::ReturnCount(bytecode));
InterpreterAssembler assembler(&state, bytecode, operand_scale);
(this->*generator)(&assembler);
- Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state);
+ // TODO(ishell): enable verification once all issues are fixed.
+ // Enable verification only in mksnapshot.
+ bool verify_graph = FLAG_csa_verify && FLAG_startup_blob != nullptr;
+ Handle<Code> code =
+ compiler::CodeAssembler::GenerateCode(&state, verify_graph);
size_t index = GetDispatchTableIndex(bytecode, operand_scale);
dispatch_table_[index] = code->entry();
TraceCodegen(code);
« no previous file with comments | « src/flag-definitions.h ('k') | test/cctest/compiler/code-assembler-tester.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698