Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/code-stubs.cc

Issue 2575473002: [interpreter][stubs] Enable graph verification for bytecode handlers and stubs included into snapsh… (Closed)
Patch Set: Addressing comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index c97ba3db2d59ed3458505b1f359f3e8432db8a34..e9e43e5250cb81b6c4cc4693176c3632626f17b2 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -437,7 +437,10 @@ Handle<Code> TurboFanCodeStub::GenerateCode() {
compiler::CodeAssemblerState state(isolate(), &zone, descriptor,
GetCodeFlags(), name);
GenerateAssembly(&state);
- return compiler::CodeAssembler::GenerateCode(&state);
+ // TODO(ishell): enable verification once all issues are fixed.
+ // Enable verification only in mksnapshot.
+ bool verify_graph = FLAG_csa_verify && FLAG_startup_blob != nullptr;
+ return compiler::CodeAssembler::GenerateCode(&state, verify_graph);
}
#define ACCESSOR_ASSEMBLER(Name) \
« no previous file with comments | « src/builtins/builtins.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698