Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/compiler/pipeline.cc

Issue 2575473002: [interpreter][stubs] Enable graph verification for bytecode handlers and stubs included into snapsh… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index b513b431f6695ed5cb69d14702198b80ed9d3e46..06f50a213a43a0c02e59f1d9675c963be10d2aa1 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1631,12 +1631,16 @@ bool PipelineImpl::OptimizeGraph(Linkage* linkage) {
return ScheduleAndSelectInstructions(linkage, true);
}
+// TODO(ishell): Remove verify_graph parameter and always enable the
+// verification once all the issues are fixed.
Handle<Code> Pipeline::GenerateCodeForCodeStub(Isolate* isolate,
CallDescriptor* call_descriptor,
Graph* graph, Schedule* schedule,
Code::Flags flags,
- const char* debug_name) {
+ const char* debug_name,
+ bool verify_graph) {
CompilationInfo info(CStrVector(debug_name), isolate, graph->zone(), flags);
+ info.set_verify_graph(verify_graph);
if (isolate->serializer_enabled()) info.PrepareForSerializing();
// Construct a pipeline for scheduling and code generation.
@@ -1772,11 +1776,7 @@ bool PipelineImpl::ScheduleAndSelectInstructions(Linkage* linkage,
info(), data->graph(), data->schedule()));
}
- // TODO(ishell): Always enable graph verification of stubs in debug mode
- // once all the issues are fixed.
- bool verify_stub_graph =
- DEBUG_BOOL && FLAG_csa_verify && data->info()->IsStub();
-
+ bool verify_stub_graph = data->info()->verify_graph();
if (verify_stub_graph || (FLAG_turbo_verify_machine_graph != nullptr &&
(!strcmp(FLAG_turbo_verify_machine_graph, "*") ||
!strcmp(FLAG_turbo_verify_machine_graph,
« src/compilation-info.h ('K') | « src/compiler/pipeline.h ('k') | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698