Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

Issue 2575423003: Fix geometry mapping issues for float under inline (Closed)
Patch Set: - Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
index 350073f43cf0682d3f919badd70ad5b98878da83..d5e3a0f438432acf523a56ff1ab21b673e20469a 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
@@ -65,6 +65,11 @@ struct PaintPropertyTreeBuilderContext {
ContainingBlockContext fixedPosition;
+ // This is the same as current.paintOffset except when a floating object has
chrishtr 2016/12/16 22:10:30 Nit: add a comma after paintOffset
+ // non-block ancestors under its containing block. Paint offsets of the
+ // non-block ancestors should not be accumulated for the floating object.
+ LayoutPoint paintOffsetForFloat;
+
// The effect hierarchy is applied by the stacking context tree. It is
// guaranteed that every DOM descendant is also a stacking context descendant.
// Therefore, we don't need extra bookkeeping for effect nodes and can
@@ -135,8 +140,8 @@ class PaintPropertyTreeBuilder {
static void updateScrollAndScrollTranslation(
const LayoutObject&,
PaintPropertyTreeBuilderContext&);
- static void updateOutOfFlowContext(const LayoutObject&,
- PaintPropertyTreeBuilderContext&);
+ static void updateOutOfFlowAndFloatContext(const LayoutObject&,
+ PaintPropertyTreeBuilderContext&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698