Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp

Issue 2575423003: Fix geometry mapping issues for float under inline (Closed)
Patch Set: SVG floating Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
index a088fbd64064f1b60ec27a4641cdc9fca7353aa2..ee0f643bf71cc7f357e415bdeb0456b92e78f9c9 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
@@ -204,6 +204,10 @@ static bool canMapBetweenLayoutObjects(const LayoutObject* layoutObject,
if (current == ancestor)
break;
+
+ if (current->isFloating() && current->parent() &&
wkorman 2017/01/04 22:27:08 Some concern re: unexpected ramifications of this,
Xianzhu 2017/01/04 22:49:59 The unit test is here: https://codereview.chromium
+ !current->parent()->isLayoutBlock())
+ return false;
}
return true;

Powered by Google App Engine
This is Rietveld 408576698